Skip to content

docs: Removes #to_json from the Failure result, the wrapper handles that#25

Merged
bougyman merged 1 commit intomainfrom
better-example
Aug 6, 2025
Merged

docs: Removes #to_json from the Failure result, the wrapper handles that#25
bougyman merged 1 commit intomainfrom
better-example

Conversation

@bougyman
Copy link
Member

@bougyman bougyman commented Aug 6, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 6, 2025 15:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes unnecessary .to_json call from the Failure result in the echo_fail endpoint, allowing the wrapper to handle JSON serialization instead of doing it manually at the endpoint level.

@BryceARich BryceARich changed the title docs: Removes #to_json from the Failure result, the wrapper handles taht docs: Removes #to_json from the Failure result, the wrapper handles that Aug 6, 2025
Copy link
Contributor

@BryceARich BryceARich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bougyman bougyman merged commit e7ef335 into main Aug 6, 2025
6 checks passed
@bougyman bougyman deleted the better-example branch August 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants